[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by r
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset |
Date: |
Wed, 5 Oct 2016 15:12:13 +0200 |
On Tue, 27 Sep 2016 11:08:53 +0100
Stefan Hajnoczi <address@hidden> wrote:
> On Mon, Sep 19, 2016 at 02:28:02PM +0100, Stefan Hajnoczi wrote:
> > virtio-blk and virtio-serial need to free VirtQueueElements during device
> > reset. Simply calling g_free(elem) is not enough because the scatter-gather
> > list should be unmapped and vq->inuse must be decremented.
> >
> > These patches address the issue. I am not including a patch that changes
> > vq->inuse = 0 to assert(!vq->inuse) in virtio_reset() yet because virtio-9p,
> > virtio-gpu, and virtio-net have code paths that do not decrement vq->inuse.
> >
> > Stefan Hajnoczi (3):
> > virtio: add virtio_detach_element()
> > virtio-blk: add missing virtio_detach_element() call
> > virtio-serial: add missing virtio_detach_element() call
> >
> > hw/block/virtio-blk.c | 1 +
> > hw/char/virtio-serial-bus.c | 14 ++++++++++++++
> > hw/virtio/virtio.c | 27 +++++++++++++++++++++++++--
> > include/hw/virtio/virtio.h | 2 ++
> > 4 files changed, 42 insertions(+), 2 deletions(-)
>
> Ping?
+1 because patch 1/3 of this series is required by:
Subject: [PATCH v4 0/9] virtio: avoid inappropriate QEMU termination in device
code
Date: Fri, 30 Sep 2016 17:12:32 +0200
Message-Id: <address@hidden>
Cheers.
--
Greg
pgpf0wA0gWkYs.pgp
Description: OpenPGP digital signature
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [Qemu-devel] [PATCH 0/3] virtio: detach VirtQueueElements freed by reset,
Greg Kurz <=