[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V6 1/2] arm64: Add an option to turn on/off vPMU
From: |
Andrew Jones |
Subject: |
Re: [Qemu-devel] [PATCH V6 1/2] arm64: Add an option to turn on/off vPMU support |
Date: |
Wed, 5 Oct 2016 09:10:10 +0200 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Tue, Oct 04, 2016 at 05:38:53PM -0400, Wei Huang wrote:
> This patch adds a pmu=[on/off] option to enable/disable vPMU support
> in guest vCPU. This option is only available for cortex-a57/cortex-53/
> host under both TCG and KVM modes, but unavailable on ARMv7 and other
> processors. It allows virt tools, such as libvirt, to determine the
> exsitence of vPMU and configure it. Note that, if nothing specified,
> the pmu option is set to AUTO as default, allowing machine-level PMU
> property to override it. Also when pmu is turned on under non-KVM mode,
> a warning message will be printed.
>
> Signed-off-by: Wei Huang <address@hidden>
> ---
> hw/arm/virt-acpi-build.c | 2 +-
> hw/arm/virt.c | 2 +-
> target-arm/cpu.c | 23 +++++++++++++++++++++++
> target-arm/cpu.h | 3 ++-
> target-arm/cpu64.c | 2 ++
> target-arm/kvm64.c | 17 ++++++++++++++---
> 6 files changed, 43 insertions(+), 6 deletions(-)
>
Please leave r-b's on patches that don't change. afaict this one
didn't change, so [again]
Reviewed-by: Andrew Jones <address@hidden>