[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options
From: |
Kevin Wolf |
Subject: |
Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options |
Date: |
Tue, 4 Oct 2016 13:59:21 +0200 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 04.10.2016 um 12:12 hat Paolo Bonzini geschrieben:
>
>
> On 04/10/2016 11:24, Kevin Wolf wrote:
> > You also need to update the options for the blockdev-add QMP command in
> > qapi/block-core.json. The relevant type is BlockdevOptionsFile.
>
> Is it? Or should he define a new BlockdevOptionsRaw, and point to it in
> the BlockdevOptions union instead of "'raw':
> 'BlockdevOptionsGenericFormat'"?
It would be the right type for the raw-posix patch as it exists today.
But you're right that for adding the option to the raw format
driver, as we requested, a new BlockdevOptionsRaw (which inherits from
BlockdevOptionsGenericFormat) is needed.
Kevin
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, (continued)
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Daniel P. Berrange, 2016/10/03
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Tomáš Golembiovský, 2016/10/03
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Daniel P. Berrange, 2016/10/03
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Kevin Wolf, 2016/10/04
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Daniel P. Berrange, 2016/10/04
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Eric Blake, 2016/10/04
- Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Tomáš Golembiovský, 2016/10/04
Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Eric Blake, 2016/10/03
Re: [Qemu-devel] [PATCH] raw-posix: add 'offset' and 'size' options, Kevin Wolf, 2016/10/04