[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct
|
From: |
Peter Maydell |
|
Subject: |
Re: [Qemu-devel] [PATCH] linux-user: use libc wrapper instead of direct mremap syscall |
|
Date: |
Fri, 30 Sep 2016 19:35:45 -0700 |
On 30 September 2016 at 16:39, Felix Janda <address@hidden> wrote:
> This commit essentially reverts commit
> 3af72a4d98dca033492102603734cbc63cd2694a, which has replaced
> five-argument calls to mremap() by direct mremap syscalls for
> compatibility with glibc older than version 2.4.
>
> The direct syscall was buggy for 64bit targets on 32bit hosts
> because of the default integer type promotions. Since glibc-2.4
> is now a decade old, we can remove this workaround.
>
> Signed-off-by: Felix Janda <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
thanks
-- PMM