[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 03/12] block/nbd: Default port in nbd_refresh
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v4 03/12] block/nbd: Default port in nbd_refresh_filename() |
Date: |
Fri, 30 Sep 2016 14:28:10 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/28/2016 03:55 PM, Max Reitz wrote:
> Instead of not emitting the port in nbd_refresh_filename(), just set it
> to the default if the user did not specify it. This makes the logic a
> bit simpler.
>
> Signed-off-by: Max Reitz <address@hidden>
> ---
> block/nbd.c | 19 ++++++-------------
> 1 file changed, 6 insertions(+), 13 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v4 00/12] qapi: Allow blockdev-add for NBD, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 01/12] block/nbd: Drop trailing "." in error messages, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 02/12] block/nbd: Reject port parameter without host, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 03/12] block/nbd: Default port in nbd_refresh_filename(), Max Reitz, 2016/09/28
- Re: [Qemu-devel] [PATCH v4 03/12] block/nbd: Default port in nbd_refresh_filename(),
Eric Blake <=
- [Qemu-devel] [PATCH v4 04/12] block/nbd: Use qdict_put(), Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 05/12] block/nbd: Add nbd_has_filename_options_conflict(), Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 06/12] block/nbd: Accept SocketAddress, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 07/12] block/nbd: Use SocketAddress options, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 08/12] qapi: Allow blockdev-add for NBD, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 09/12] iotests.py: Add qemu_nbd function, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 10/12] iotests.py: Allow concurrent qemu instances, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 11/12] socket_scm_helper: Accept fd directly, Max Reitz, 2016/09/28
- [Qemu-devel] [PATCH v4 12/12] iotests: Add test for NBD's blockdev-add interface, Max Reitz, 2016/09/28