Re: [Qemu-devel] [Bug 1625987] Re: target-arm/translate-a64.c:2028: possible coding error ?

[Edgar E. Iglesias]

On Thu, Sep 29, 2016 at 06:40:53PM -0700, Peter Maydell wrote:
> On 22 September 2016 at 02:53, Peter Maydell <address@hidden> wrote:
> > This is clearly a bug, but your suggested change won't deal with the
> > problem, which is that we're trying to set a bool so the ? 32 : 64
> > construct is just wrong.
> 
> > Bug description:
> >   target-arm/translate-a64.c:2028:37: warning: ?: using integer
> >   constants in boolean context [-Wint-in-bool-context]
> >
> >   Source code is
> >
> >           bool iss_sf = opc == 0 ? 32 : 64;
> 
> Edgar, did you want to look at a fix for this? It was introduced
> in your commit aaa1f954d4 adding syndrome info for loads and stores.

Hi Peter,

Yes, I've just posted a fix to the list.
It should have been:

bool iss_sf = opc == 0 ? false : true;

Cheers,
Edgar