Re: [Qemu-devel] [Qemu-block] block/ssh:Allow blockdev-add for ssh

[Kevin Wolf]

Am 29.09.2016 um 10:07 hat Richard W.M. Jones geschrieben:
> On Thu, Sep 29, 2016 at 01:05:48PM +0530, Ashijeet Acharya wrote:
> > Hi all,
> > 
> > I was trying to convert SSH driver to support 'blockdev-add' and so
> > far I have tried to figure out what the struct 'BlockdevOptionsSsh' in
> > block-core.json should look like,
> > 
> > { 'struct': 'BlockdevOptionsSsh',
> >   'data': { 'tcp': 'InetSocketAddress',
> >              'path': 'str' } }
> > 
> > Naive question but I have to ask, Am I missing something?
> > 
> > As far as I know, ssh only supports 'tcp' right? So using
> > 'InetSocketAddress' should be good enough. (like the TODO says)
> > 
> > I had a discussion with Kevin about this and he thinks, maybe
> > 'SocketAddress' can be used too because the restriction comes from the
> > qemu block driver rather than the backend. He advised me to get an
> > opinion on this one from the maintainers of SSH.
> 
> I have no idea.

I searched the net a bit and it seems that SSH over Unix domain sockets
isn't a thing. So it might actually be okay to restrict the QEMU block
driver to TCP, too, and therefore use InetSocketAddress.

Any other opinions?

Kevin