Re: [Qemu-devel] [PATCH 5/5] intel_iommu: do not allow EIM without KVM support

[Paolo Bonzini]

----- Original Message -----
> From: "Radim Krčmář" <address@hidden>
> To: "Paolo Bonzini" <address@hidden>
> Cc: address@hidden, "Peter Xu" <address@hidden>, "Igor Mammedov" 
> <address@hidden>, "Richard Henderson"
> <address@hidden>, "Eduardo Habkost" <address@hidden>, "Michael S. Tsirkin" 
> <address@hidden>
> Sent: Tuesday, September 27, 2016 4:01:39 PM
> Subject: Re: [PATCH 5/5] intel_iommu: do not allow EIM without KVM support
> 
> 2016-09-23 11:27+0200, Paolo Bonzini:
> > Since the whole IOMMU feature is new and somewhat experimental, I think
> > it's okay to just make EIM the default for >=2.8 machine types if KVM is
> > on (using DEFINE_PROP_ON_OFF_AUTO; auto means true if KVM is on and
> 
> Sounds good.

BTW this also means KVM+vIOMMU requires 4.8.  Let's remember to document
it in the release notes.

> > false otherwise, and pc-2.7 would set eim=off).
> 
> What about eim=on in pc-2.7, to avoid breaking migration?

Yup, just a thinko.

Paolo