Re: [Qemu-devel] [PATCH RFC v1 01/29] target-arc: initial commit

[Richard Henderson]

On 09/25/2016 06:22 PM, Max Filippov wrote:
> Hello,
> 
> On Tue, Sep 20, 2016 at 4:31 PM, Richard Henderson <address@hidden> wrote:
>>> +        if (ctx.npc == env->lpe) {
>> You can't look at the contents of ENV during translation.
>>
>> You'll need to implement this feature similar to how it's done for xtensa.
>> See helper_wsr_lbeg, helper_wsr_lend, and gen_check_loop_end.
> 
> I think it's fairly expensive solution, as it allows to have only one TB with
> zero overhead loop at a time. I'm looking at ways to optimize it,
> perhaps recording lbeg in the TB's cs_base.
> 

It may be expensive, but at least it works.  Unlike the mechanism quoted above,
which doesn't work at all.


r~