[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 02/18] qemu: use bdrv_flush_all for vm_stop et al
From: |
Kevin Wolf |
Subject: |
[Qemu-devel] [PULL 02/18] qemu: use bdrv_flush_all for vm_stop et al |
Date: |
Tue, 27 Sep 2016 15:53:45 +0200 |
From: John Snow <address@hidden>
Reimplement bdrv_flush_all for vm_stop. In contrast to blk_flush_all,
bdrv_flush_all does not have device model restrictions. This allows
us to flush and halt unconditionally without error.
This allows us to do things like migrate when we have a device with
an open tray, but has a node that may need to be flushed, or nodes
that aren't currently attached to any device and need to be flushed.
Specifically, this allows us to migrate when we have a CDROM with
an open tray.
Signed-off-by: John Snow <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
Reviewed-by: Max Reitz <address@hidden>
Acked-by: Fam Zheng <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
---
cpus.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpus.c b/cpus.c
index e39ccb7..96d9352 100644
--- a/cpus.c
+++ b/cpus.c
@@ -751,7 +751,7 @@ static int do_vm_stop(RunState state)
}
bdrv_drain_all();
- ret = blk_flush_all();
+ ret = bdrv_flush_all();
return ret;
}
@@ -1494,7 +1494,7 @@ int vm_stop_force_state(RunState state)
bdrv_drain_all();
/* Make sure to return an error if the flush in a previous vm_stop()
* failed. */
- return blk_flush_all();
+ return bdrv_flush_all();
}
}
--
1.8.3.1
- [Qemu-devel] [PULL 14/18] blockdev: Add dynamic generation of module_block.h, (continued)
- [Qemu-devel] [PULL 14/18] blockdev: Add dynamic generation of module_block.h, Max Reitz, 2016/09/14
- [Qemu-devel] [PULL 16/18] blockdev: Modularize nfs block driver, Max Reitz, 2016/09/14
- [Qemu-devel] [PULL 15/18] blockdev: Add dynamic module loading for block drivers, Max Reitz, 2016/09/14
- [Qemu-devel] [PULL 17/18] commit: get the overlay node before manipulating the backing chain, Max Reitz, 2016/09/14
- [Qemu-devel] [PULL 18/18] iotest 055: refactor and speed up, Max Reitz, 2016/09/14
- Re: [Qemu-devel] [PULL 00/18] Block layer patches, no-reply, 2016/09/14
- Re: [Qemu-devel] [PULL 00/18] Block layer patches, Peter Maydell, 2016/09/15
- [Qemu-devel] [PULL 00/18] Block layer patches, Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 05/18] block: Drop aio/cache consistency check from qmp_blockdev_add(), Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 02/18] qemu: use bdrv_flush_all for vm_stop et al,
Kevin Wolf <=
- [Qemu-devel] [PULL 01/18] block: reintroduce bdrv_flush_all, Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 03/18] block-backend: remove blk_flush_all, Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 06/18] block/qapi: Use separate options type for curl driver, Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 08/18] block: Parse 'detect-zeroes' in bdrv_open_common(), Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 04/18] block: Fix error path in qmp_blockdev_change_medium(), Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 11/18] block: Remove qemu_root_bds_opts, Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 09/18] block: Use 'detect-zeroes' option for 'blockdev-change-medium', Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 16/18] coroutine-sigaltstack: use helper for allocating stack memory, Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 10/18] block: Move 'discard' option to bdrv_open_common(), Kevin Wolf, 2016/09/27
- [Qemu-devel] [PULL 18/18] coroutine: reduce stack size to 60kB, Kevin Wolf, 2016/09/27