[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 0/6] intc: change 'info irq' and 'info pic' t
From: |
David Gibson |
Subject: |
Re: [Qemu-devel] [PATCH v2 0/6] intc: change 'info irq' and 'info pic' to be target-agnostic |
Date: |
Tue, 27 Sep 2016 14:08:55 +1000 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Mon, Sep 26, 2016 at 10:23:22PM +0200, Hervé Poussineau wrote:
> Hi,
>
> This patchset aims at genericizing the 'info irq' and 'info pic' HMP
> commands, so
> that it is available on all machines and can display details about more than
> one
> interrupt controller per machine.
>
> Patch 1 adds a new interface InterruptStatsProvider, which is used to:
> - gather statistics for the 'info irq' command
> - print some text when 'info pic' is called
>
> Patches 2 to 4 implement InterruptStatsProvider interface on interrupt
> controllers
> which have ad-hock code to handle 'info irq'/'info pic' commands.
>
> Patch 5 removes ad-hock code, and replaces it by a generic version. You can
> get
> details about multiple interrupt controllers per machine starting here.
>
> Patch 6 makes 'info irq'/'info pic' commands available on all architectures.
> For example, Alpha clipper machine is now able to display details about the
> i8259 interrupt controller.
Thanks for doing this. I didn't spot your first version of this, but
it's a rather more thorough approach to some cleanups I attempted a
while back, but never got around to completing. Looks like a nice
approach.
>
> Changes since v1:
> - renamed interface from IntCtrl to InterruptStatsProvider
>
> Hervé
>
> Hervé Poussineau (6):
> intc: add an interface to gather statistics/informations on interrupt
> controllers
> intc/i8259: implement InterruptStatsProvider interface
> intc/slavio_intctl: implement InterruptStatsProvider interface
> intc/lm32_pic: implement InterruptStatsProvider interface
> intc: make HMP 'info irq' and 'info pic' commands use
> InterruptStatsProvider interface
> intc: make HMP 'info irq' and 'info pic' commands available on all
> targets
>
> hmp-commands-info.hx | 17 +----------
> hmp.c | 65 +++++++++++++++++++++++++++++++++++++++++
> hmp.h | 2 ++
> hw/intc/Makefile.objs | 1 +
> hw/intc/i8259.c | 73
> +++++++++++++++++++++++-----------------------
> hw/intc/intc.c | 41 ++++++++++++++++++++++++++
> hw/intc/lm32_pic.c | 63 ++++++++++++++++++---------------------
> hw/intc/slavio_intctl.c | 67 ++++++++++++++++++++++--------------------
> hw/sparc/sun4m.c | 15 +---------
> include/hw/i386/pc.h | 2 --
> include/hw/intc/intc.h | 30 +++++++++++++++++++
> include/hw/lm32/lm32_pic.h | 3 --
> include/hw/sparc/sun4m.h | 8 -----
> monitor.c | 6 ----
> 14 files changed, 241 insertions(+), 152 deletions(-)
> create mode 100644 hw/intc/intc.c
> create mode 100644 include/hw/intc/intc.h
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-devel] [PATCH v2 2/6] intc/i8259: implement InterruptStatsProvider interface, (continued)
[Qemu-devel] [PATCH v2 5/6] intc: make HMP 'info irq' and 'info pic' commands use InterruptStatsProvider interface, Hervé Poussineau, 2016/09/26
[Qemu-devel] [PATCH v2 1/6] intc: add an interface to gather statistics/informations on interrupt controllers, Hervé Poussineau, 2016/09/26
[Qemu-devel] [PATCH v2 6/6] intc: make HMP 'info irq' and 'info pic' commands available on all targets, Hervé Poussineau, 2016/09/26
[Qemu-devel] [PATCH v2 3/6] intc/slavio_intctl: implement InterruptStatsProvider interface, Hervé Poussineau, 2016/09/26
Re: [Qemu-devel] [PATCH v2 0/6] intc: change 'info irq' and 'info pic' to be target-agnostic,
David Gibson <=