Re: [Qemu-devel] [PATCH v3 2/9] virtio-blk: make some functions static

[Stefan Hajnoczi]

On Mon, Sep 26, 2016 at 10:34:05AM +0200, Greg Kurz wrote:
> Some functions that were called from the dataplane code are now only used
> locally:
> 
> virtio_blk_init_request()
> virtio_blk_handle_request()
> virtio_blk_submit_multireq()
> 
> since commit "03de2f527499 virtio-blk: do not use vring in dataplane", and
> 
> virtio_blk_free_request()
> 
> since commit "6aa46d8ff1ee virtio: move VirtQueueElement at the beginning
> of the structs".
> 
> This patch converts them to static.
> 
> Signed-off-by: Greg Kurz <address@hidden>
> ---
> v3: This was "virtio-blk: turn virtio_blk_handle_request() into a static
>     function" in v2. It turns out that there are some more candidates.
> ---
>  hw/block/virtio-blk.c          |   10 +++++-----
>  include/hw/virtio/virtio-blk.h |    8 --------
>  2 files changed, 5 insertions(+), 13 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>

signature.asc
Description: PGP signature