qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v2 3/7] block/qapi: Move 'aio' option to file dr


From: Kevin Wolf
Subject: Re: [Qemu-devel] [PATCH v2 3/7] block/qapi: Move 'aio' option to file driver
Date: Mon, 26 Sep 2016 11:16:45 +0200
User-agent: Mutt/1.5.21 (2010-09-15)

Am 23.09.2016 um 16:40 hat Eric Blake geschrieben:
> On 09/23/2016 09:32 AM, Kevin Wolf wrote:
> > The option whether or not to use a native AIO interface really isn't a
> > generic option for all drivers, but only applies to the native file
> > protocols. This patch moves the option in blockdev-add to the
> > appropriate places (raw-posix and raw-win32).
> > 
> > We still have to keep the flag BDRV_O_NATIVE_AIO for compatibility
> > because so far the AIO option was usually specified on the wrong layer
> > (the top-level format driver, which didn't even look at it) and then
> > inherited by the protocol driver (where it was actually used). We can't
> > forbid this use except in new interfaces.
> > 
> > Signed-off-by: Kevin Wolf <address@hidden>
> > ---
> >  block/raw-posix.c      | 44 ++++++++++++++++++++++++---------------
> >  block/raw-win32.c      | 56 
> > +++++++++++++++++++++++++++++++++++++++++++++-----
> >  qapi/block-core.json   |  6 +++---
> >  tests/qemu-iotests/087 |  4 ++--
> >  4 files changed, 83 insertions(+), 27 deletions(-)
> > 
> 
> > +++ b/qapi/block-core.json
> > @@ -1724,11 +1724,13 @@
> >  # Driver specific block device options for the file backend.
> >  #
> >  # @filename:    path to the image file
> > +# @aio:         #optional AIO backend (default: threads)
> 
> Missed this last time, but probably worth a '(since 2.8)' marker.

I'm not sure how useful this is when the whole blockdev-add command is
still experimental and we're going to break it incompatibly by removing
the "options" layer. But we have the annotation elsewhere, so I'll add
it.

Maybe the patch that breaks compatibility should remove the annotation
everywhere again.

Kevin

Attachment: pgpSKEuYBFRym.pgp
Description: PGP signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]