[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v5 5/9] savevm: add public save_vmstate function
From: |
Pavel Dovgalyuk |
Subject: |
[Qemu-devel] [PATCH v5 5/9] savevm: add public save_vmstate function |
Date: |
Mon, 26 Sep 2016 11:08:27 +0300 |
User-agent: |
StGit/0.16 |
This patch introduces save_vmstate function to allow saving and loading
vmstates from the replay module.
Signed-off-by: Pavel Dovgalyuk <address@hidden>
---
include/sysemu/sysemu.h | 1 +
migration/savevm.c | 33 ++++++++++++++++++++++-----------
2 files changed, 23 insertions(+), 11 deletions(-)
diff --git a/include/sysemu/sysemu.h b/include/sysemu/sysemu.h
index ee7c760..b471b1e 100644
--- a/include/sysemu/sysemu.h
+++ b/include/sysemu/sysemu.h
@@ -78,6 +78,7 @@ void qemu_add_machine_init_done_notifier(Notifier *notify);
void qemu_remove_machine_init_done_notifier(Notifier *notify);
void hmp_savevm(Monitor *mon, const QDict *qdict);
+int save_vmstate(Monitor *mon, const char *name);
int load_vmstate(const char *name);
void hmp_delvm(Monitor *mon, const QDict *qdict);
void hmp_info_snapshots(Monitor *mon, const QDict *qdict);
diff --git a/migration/savevm.c b/migration/savevm.c
index 33a2911..f571da6 100644
--- a/migration/savevm.c
+++ b/migration/savevm.c
@@ -1958,38 +1958,40 @@ int qemu_loadvm_state(QEMUFile *f)
return ret;
}
-void hmp_savevm(Monitor *mon, const QDict *qdict)
+int save_vmstate(Monitor *mon, const char *name)
{
BlockDriverState *bs, *bs1;
QEMUSnapshotInfo sn1, *sn = &sn1, old_sn1, *old_sn = &old_sn1;
- int ret;
+ int ret = -1;
QEMUFile *f;
int saved_vm_running;
uint64_t vm_state_size;
qemu_timeval tv;
struct tm tm;
- const char *name = qdict_get_try_str(qdict, "name");
Error *local_err = NULL;
AioContext *aio_context;
if (!bdrv_all_can_snapshot(&bs)) {
monitor_printf(mon, "Device '%s' is writable but does not "
"support snapshots.\n", bdrv_get_device_name(bs));
- return;
+ return ret;
}
/* Delete old snapshots of the same name */
- if (name && bdrv_all_delete_snapshot(name, &bs1, &local_err) < 0) {
- error_reportf_err(local_err,
- "Error while deleting snapshot on device '%s': ",
- bdrv_get_device_name(bs1));
- return;
+ if (name) {
+ ret = bdrv_all_delete_snapshot(name, &bs1, &local_err);
+ if (ret < 0) {
+ error_reportf_err(local_err,
+ "Error while deleting snapshot on device '%s': ",
+ bdrv_get_device_name(bs1));
+ return ret;
+ }
}
bs = bdrv_all_find_vmstate_bs();
if (bs == NULL) {
monitor_printf(mon, "No block device can accept snapshots\n");
- return;
+ return ret;
}
aio_context = bdrv_get_aio_context(bs);
@@ -1998,7 +2000,7 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
ret = global_state_store();
if (ret) {
monitor_printf(mon, "Error saving global state\n");
- return;
+ return ret;
}
vm_stop(RUN_STATE_SAVE_VM);
@@ -2044,13 +2046,22 @@ void hmp_savevm(Monitor *mon, const QDict *qdict)
if (ret < 0) {
monitor_printf(mon, "Error while creating snapshot on '%s'\n",
bdrv_get_device_name(bs));
+ goto the_end;
}
+ ret = 0;
+
the_end:
aio_context_release(aio_context);
if (saved_vm_running) {
vm_start();
}
+ return ret;
+}
+
+void hmp_savevm(Monitor *mon, const QDict *qdict)
+{
+ save_vmstate(mon, qdict_get_try_str(qdict, "name"));
}
void qmp_xen_save_devices_state(const char *filename, Error **errp)
- [Qemu-devel] [PATCH v5 0/9] replay additions, Pavel Dovgalyuk, 2016/09/26
- [Qemu-devel] [PATCH v5 1/9] replay: move internal data to the structure, Pavel Dovgalyuk, 2016/09/26
- [Qemu-devel] [PATCH v5 3/9] replay: allow replay stopping and restarting, Pavel Dovgalyuk, 2016/09/26
- [Qemu-devel] [PATCH v5 2/9] replay: vmstate for replay module, Pavel Dovgalyuk, 2016/09/26
- [Qemu-devel] [PATCH v5 4/9] record/replay: add network support, Pavel Dovgalyuk, 2016/09/26
- [Qemu-devel] [PATCH v5 5/9] savevm: add public save_vmstate function,
Pavel Dovgalyuk <=
- [Qemu-devel] [PATCH v5 6/9] replay: save/load initial state, Pavel Dovgalyuk, 2016/09/26
- [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Pavel Dovgalyuk, 2016/09/26
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Kevin Wolf, 2016/09/26
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Pavel Dovgalyuk, 2016/09/26
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Kevin Wolf, 2016/09/26
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Pavel Dovgalyuk, 2016/09/27
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Kevin Wolf, 2016/09/28
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Pavel Dovgalyuk, 2016/09/28
- Re: [Qemu-devel] [PATCH v5 7/9] block: don't make snapshots for filters, Kevin Wolf, 2016/09/28