Re: [Qemu-devel] [PATCH 2/4] target-microblaze: Do not dump cpu state with -d in_asm

[Edgar E. Iglesias]

On Fri, Sep 23, 2016 at 08:29:09AM -0700, Richard Henderson wrote:
> Dumping cpu state is what -d cpu is for.
>

Reviewed-by: Edgar E. Iglesias <address@hidden>


> Cc: Edgar E. Iglesias <address@hidden>
> Signed-off-by: Richard Henderson <address@hidden>
> ---
>  target-microblaze/translate.c | 9 +--------
>  1 file changed, 1 insertion(+), 8 deletions(-)
> 
> diff --git a/target-microblaze/translate.c b/target-microblaze/translate.c
> index 80098ec..5a4a8b9 100644
> --- a/target-microblaze/translate.c
> +++ b/target-microblaze/translate.c
> @@ -1670,13 +1670,6 @@ void gen_intermediate_code(CPUMBState *env, struct 
> TranslationBlock *tb)
>          cpu_abort(cs, "Microblaze: unaligned PC=%x\n", pc_start);
>      }
>  
> -    if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)) {
> -#if !SIM_COMPAT
> -        qemu_log("--------------\n");
> -        log_cpu_state(CPU(cpu), 0);
> -#endif
> -    }
> -
>      next_page_start = (pc_start & TARGET_PAGE_MASK) + TARGET_PAGE_SIZE;
>      num_insns = 0;
>      max_insns = tb->cflags & CF_COUNT_MASK;
> @@ -1820,7 +1813,7 @@ void gen_intermediate_code(CPUMBState *env, struct 
> TranslationBlock *tb)
>  #if !SIM_COMPAT
>      if (qemu_loglevel_mask(CPU_LOG_TB_IN_ASM)
>          && qemu_log_in_addr_range(pc_start)) {
> -        qemu_log("\n");
> +        qemu_log("--------------\n");
>  #if DISAS_GNU
>          log_target_disas(cs, pc_start, dc->pc - pc_start, 0);
>  #endif
> -- 
> 2.7.4
>