[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
From: |
Felipe Franciosi |
Subject: |
Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result |
Date: |
Fri, 23 Sep 2016 13:02:39 +0000 |
> On 23 Sep 2016, at 09:15, Markus Armbruster <address@hidden> wrote:
>
> Eric Blake <address@hidden> writes:
>
>> On 09/22/2016 06:51 AM, Markus Armbruster wrote:
>>>>
>>>> I think the file probably should not have been listed as public domain
>>>> in the first place, as its initial contents were copied from qemu-common.h
>>>> which is not public domain.
>>>
>>> Ewww! Needs fixing.
>>
>> Indeed. Commit 5c02632 shows the initial file creation, but Luiz used a
>> different email address at that time. What would be the best line to
>> list as a copyright holder on both qemu-common.h and on compiler.h?
>
> Since qemu-common.h carried no licence notice back then[*], adding the
> line "/* public domain */" was to compiler.h was wrong, and is probably
> legally void. The immediate fix is therefore dropping that line. Then
> the project-wide license applies: GPLv2+.
>
> We can always copy the standard GPLv2+ licence notice to files that
> don't have one, if we think that's useful.
>
>>> Since qemu-common.h carries no license, GPLv2+ applies.
>
>
> [*] It still doesn't, but that's immaterial.
Seems like all of us agree on that, so I sent another patch just for this. Once
it's in, we can go back to adding the 'ignore_value()' macro and figuring out
what to do with 'replay'.
http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg06206.html
Cheers,
Felipe
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, (continued)
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Felipe Franciosi, 2016/09/21
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Daniel P. Berrange, 2016/09/21
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Felipe Franciosi, 2016/09/21
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Eric Blake, 2016/09/21
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Markus Armbruster, 2016/09/21
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Eric Blake, 2016/09/21
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Daniel P. Berrange, 2016/09/22
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Markus Armbruster, 2016/09/22
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Eric Blake, 2016/09/22
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Markus Armbruster, 2016/09/23
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result,
Felipe Franciosi <=
- Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, Eric Blake, 2016/09/21
Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result, no-reply, 2016/09/21