qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result


From: Markus Armbruster
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
Date: Fri, 23 Sep 2016 10:15:28 +0200
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)

Eric Blake <address@hidden> writes:

> On 09/22/2016 06:51 AM, Markus Armbruster wrote:
>>>
>>> I think the file probably should not have been listed as public domain
>>> in the first place, as its initial contents were copied from qemu-common.h
>>> which is not public domain.
>> 
>> Ewww!  Needs fixing.
>
> Indeed.  Commit 5c02632 shows the initial file creation, but Luiz used a
> different email address at that time.  What would be the best line to
> list as a copyright holder on both qemu-common.h and on compiler.h?

Since qemu-common.h carried no licence notice back then[*], adding the
line "/* public domain */" was to compiler.h was wrong, and is probably
legally void.  The immediate fix is therefore dropping that line.  Then
the project-wide license applies: GPLv2+.

We can always copy the standard GPLv2+ licence notice to files that
don't have one, if we think that's useful.

>> Since qemu-common.h carries no license, GPLv2+ applies.


[*] It still doesn't, but that's immaterial.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]