[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/2] Produce better termination message |
Date: |
Thu, 22 Sep 2016 18:43:36 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 21/09/2016 18:27, Michal Privoznik wrote:
> This is v2 of:
> http://lists.nongnu.org/archive/html/qemu-devel/2016-09/msg05058.html
>
> Diff to v2:
> - In 1/2 I've dropped stdio funcs in favour of g_file_get_contents() (thanks
> Dan!)
>
> Michal Privoznik (2):
> util: Introduce qemu_get_pid_name
> qemu_kill_report: Report PID name too
>
> include/qemu/osdep.h | 10 ++++++++++
> util/oslib-posix.c | 27 +++++++++++++++++++++++++++
> util/oslib-win32.c | 7 +++++++
> vl.c | 8 ++++++--
> 4 files changed, 50 insertions(+), 2 deletions(-)
>
Patch 2/2 breaks "make check". You cannot call malloc from a signal
handler, and this shows as a deadlock in
/x86_64/virtio/scsi/pci/hotplug. You have to use the large buffer,
_but_ I cannot just keep patch 2 because you also have to use
open/read/close instead of stdio.
Thanks,
Paolo