Re: [Qemu-devel] [PATCH 08/16] cpus-common: fix uninitialized variable use in run_on_cpu

[Alex Bennée]

Paolo Bonzini <address@hidden> writes:

> Signed-off-by: Paolo Bonzini <address@hidden>
> ---
>  cpus-common.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/cpus-common.c b/cpus-common.c
> index b98f548..cdfdb14 100644
> --- a/cpus-common.c
> +++ b/cpus-common.c
> @@ -88,8 +88,7 @@ struct qemu_work_item {
>      struct qemu_work_item *next;
>      run_on_cpu_func func;
>      void *data;
> -    int done;
> -    bool free;
> +    bool free, done;
>  };
>
>  static void queue_work_on_cpu(CPUState *cpu, struct qemu_work_item *wi)
> @@ -120,6 +119,7 @@ void do_run_on_cpu(CPUState *cpu, run_on_cpu_func func, 
> void *data,
>
>      wi.func = func;
>      wi.data = data;
> +    wi.done = false;
>      wi.free = false;
>
>      queue_work_on_cpu(cpu, &wi);

Reviewed-by: Alex Bennée <address@hidden>

--
Alex Bennée