Re: [Qemu-devel] [PATCH v6 2/8] hw/intc/arm_gicv3_its: Implement ITS base class

[Peter Maydell]

On 9 September 2016 at 18:30, Eric Auger <address@hidden> wrote:
> From: Pavel Fedin <address@hidden>
>
> This is the basic skeleton for both KVM and software-emulated ITS.
> Since we already prepare status structure, we also introduce complete
> VMState description. But, because we currently have no migratable
> implementations, we also set unmigratable flag.
>
> Signed-off-by: Pavel Fedin <address@hidden>
> Signed-off-by: Eric Auger <address@hidden>
>
> ---
> v5 -> v6:
> - rename iomem_its into iomem_its_translation
> - remove vmstate_its fields since the device is not yet
>   migratable
> - fix gicv3_its_trans_write print format
> - add migration_blocker
>
> v4 -> v5:
> - send_msi can return 0 meaning the MSI was rejected by guest. Handle this
>   value as an error
>
> v3 -> v4:
> - fix compilation error
> - msi_supported -> msi_nonbroken
> - streamid -> requester_id
> - use PRIx64
> - read ops uses _with_attrs form
> - 16/32b write access allowed to GITS_TRANSLATER
> - move its_class_name in kvm_arm.h and remove #ifdef TARGET_AARCH64
> - add new kvm device dev_fd field
> - add new gits_translater_gpa field in GICv3ITSState
> ---
>  hw/intc/Makefile.objs                  |   1 +
>  hw/intc/arm_gicv3_its_common.c         | 148 
> +++++++++++++++++++++++++++++++++
>  include/hw/intc/arm_gicv3_its_common.h |  77 +++++++++++++++++
>  target-arm/kvm_arm.h                   |  19 +++++
>  4 files changed, 245 insertions(+)
>  create mode 100644 hw/intc/arm_gicv3_its_common.c
>  create mode 100644 include/hw/intc/arm_gicv3_its_common.h

Reviewed-by: Peter Maydell <address@hidden>

thanks
-- PMM