Re: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL 00/44] ppc-for-2.8 queue 20160922

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
10155e5 monitor: fix crash for platforms without a CPU 0
62e3bd0 linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP
b102077 ppc/kvm: Mark 64kB page size support as disabled if not available
7f80fc2 ppc/xics: An ICS with offset 0 is assumed to be uninitialized
3a441d9 ppc/xics: account correct irq status
c3a4b1b Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on KVM/PPC64.
fd8665b target-ppc: tlbie/tlbivax should have global effect
cc456c6 target-ppc: add flag in check_tlb_flush()
55dad49 target-ppc: add TLB_NEED_LOCAL_FLUSH flag
62b4ec2 spapr: Introduce sPAPRCPUCoreClass
856507b target-ppc: implement darn instruction
414ff66 target-ppc: add stxsi[bh]x instruction
240ae11 target-ppc: add lxsi[bw]zx instruction
85a19da target-ppc: add xxspltib instruction
6fa63cf target-ppc: consolidate store conditional
b00e42b target-ppc: move out stqcx impementation
2f8a08d target-ppc: consolidate load with reservation
469eff3 target-ppc: convert st[16, 32, 64]r to use new macro
4d39de9 target-ppc: convert st64 to use new macro
43eb13b target-ppc: consolidate store operations
34c8fe6 target-ppc: convert ld[16, 32, 64]ur to use new macro
101007d target-ppc: convert ld64 to use new macro
bcee3cb target-ppc: consolidate load operations
051f587 spapr_vscsi: convert to trace framework instead of DPRINTF
89e3e92 spapr_llan: convert to trace framework instead of DPRINTF
a571fdb spapr_vio: convert to trace framework instead of DPRINTF
dab49ae spapr_rtas: convert to trace framework instead of DPRINTF
4a26d26 spapr_drc: convert to trace framework instead of DPRINTF
7d01ec1 adb.c: prevent NO_KEY value from going to guest
8085ff6 adb.c: correct several key assignments
f874a71 adb.c: add support for QKeyCode
717522b adb-keys.h: initial commit
8649f62 MAINTAINERS: add sPAPR tests
37d9fc0 tests: add RTAS command in the protocol
6e59ba8 libqos: define SPAPR libqos functions
b19670a qtest: replace strtoXX() by qemu_strtoXX()
37fb7b9 ppc: Fix signal delivery in ppc-user and ppc64-user
5178d45 target-ppc: add vector permute right indexed instruction
a335f06 target-ppc: add vector bit permute doubleword instruction
1d280fb target-ppc: add vector count trailing zeros instructions
3c42dd9 target-ppc: add vector extract instructions
e1dc618 target-ppc: add vector insert instructions
4411d8a ppc: restrict the use of the rfi instruction
d2584ac MAINTAINERS: Add some missing ppc-related files

=== OUTPUT BEGIN ===
Checking PATCH 1/44: MAINTAINERS: Add some missing ppc-related files...
Checking PATCH 2/44: ppc: restrict the use of the rfi instruction...
Checking PATCH 3/44: target-ppc: add vector insert instructions...
Checking PATCH 4/44: target-ppc: add vector extract instructions...
Checking PATCH 5/44: target-ppc: add vector count trailing zeros instructions...
Checking PATCH 6/44: target-ppc: add vector bit permute doubleword 
instruction...
Checking PATCH 7/44: target-ppc: add vector permute right indexed instruction...
Checking PATCH 8/44: ppc: Fix signal delivery in ppc-user and ppc64-user...
Checking PATCH 9/44: qtest: replace strtoXX() by qemu_strtoXX()...
Checking PATCH 10/44: libqos: define SPAPR libqos functions...
Checking PATCH 11/44: tests: add RTAS command in the protocol...
Checking PATCH 12/44: MAINTAINERS: add sPAPR tests...
Checking PATCH 13/44: adb-keys.h: initial commit...
ERROR: line over 90 characters
#31: FILE: include/hw/input/adb-keys.h:14:
+ *  Additional information: 
http://www.archive.org/stream/apple-guide-macintosh-family-hardware/Apple_Guide_to_the_Macintosh_Family_Hardware_2e#page/n345/mode/2up

total: 1 errors, 0 warnings, 141 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 14/44: adb.c: add support for QKeyCode...
Checking PATCH 15/44: adb.c: correct several key assignments...
Checking PATCH 16/44: adb.c: prevent NO_KEY value from going to guest...
Checking PATCH 17/44: spapr_drc: convert to trace framework instead of 
DPRINTF...
Checking PATCH 18/44: spapr_rtas: convert to trace framework instead of 
DPRINTF...
Checking PATCH 19/44: spapr_vio: convert to trace framework instead of 
DPRINTF...
Checking PATCH 20/44: spapr_llan: convert to trace framework instead of 
DPRINTF...
Checking PATCH 21/44: spapr_vscsi: convert to trace framework instead of 
DPRINTF...
Checking PATCH 22/44: target-ppc: consolidate load operations...
Checking PATCH 23/44: target-ppc: convert ld64 to use new macro...
Checking PATCH 24/44: target-ppc: convert ld[16, 32, 64]ur to use new macro...
Checking PATCH 25/44: target-ppc: consolidate store operations...
Checking PATCH 26/44: target-ppc: convert st64 to use new macro...
Checking PATCH 27/44: target-ppc: convert st[16, 32, 64]r to use new macro...
Checking PATCH 28/44: target-ppc: consolidate load with reservation...
Checking PATCH 29/44: target-ppc: move out stqcx impementation...
Checking PATCH 30/44: target-ppc: consolidate store conditional...
Checking PATCH 31/44: target-ppc: add xxspltib instruction...
ERROR: Macros with complex values should be enclosed in parenthesis
#66: FILE: target-ppc/translate/vsx-ops.inc.c:23:
+#define GEN_XX1FORM(name, opc2, opc3, fl2)                              \
+GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 0, opc3, 0, PPC_NONE, fl2), \
+GEN_HANDLER2_E(name, #name, 0x3C, opc2 | 1, opc3, 0, PPC_NONE, fl2)

total: 1 errors, 0 warnings, 51 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 32/44: target-ppc: add lxsi[bw]zx instruction...
Checking PATCH 33/44: target-ppc: add stxsi[bh]x instruction...
Checking PATCH 34/44: target-ppc: implement darn instruction...
Checking PATCH 35/44: spapr: Introduce sPAPRCPUCoreClass...
Checking PATCH 36/44: target-ppc: add TLB_NEED_LOCAL_FLUSH flag...
Checking PATCH 37/44: target-ppc: add flag in check_tlb_flush()...
Checking PATCH 38/44: target-ppc: tlbie/tlbivax should have global effect...
Checking PATCH 39/44: Enable H_CLEAR_MOD and H_CLEAR_REF hypercalls on 
KVM/PPC64....
Checking PATCH 40/44: ppc/xics: account correct irq status...
Checking PATCH 41/44: ppc/xics: An ICS with offset 0 is assumed to be 
uninitialized...
Checking PATCH 42/44: ppc/kvm: Mark 64kB page size support as disabled if not 
available...
Checking PATCH 43/44: linux-user: ppc64: fix ARCH_206 bit in AT_HWCAP...
Checking PATCH 44/44: monitor: fix crash for platforms without a CPU 0...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden