Re: [Qemu-devel] [PATCH] linux-user: fix mremap for 64bit targets on 32bit hosts

[Riku Voipio]

Hi,

On Sat, Sep 17, 2016 at 09:20:14PM -0400, Felix Janda wrote:
> Signed-off-by: Felix Janda <address@hidden>

Have you run the mremap tests of ltp with this on your host/guest
combo? 

> ---
>  linux-user/mmap.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/mmap.c b/linux-user/mmap.c
> index c4371d9..4882816 100644
> --- a/linux-user/mmap.c
> +++ b/linux-user/mmap.c
> @@ -682,7 +682,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong 
> old_size,
>  
>      if (flags & MREMAP_FIXED) {
>          host_addr = (void *) syscall(__NR_mremap, g2h(old_addr),
> -                                     old_size, new_size,
> +                                     (size_t) old_size, (size_t) new_size,
>                                       flags,
>                                       g2h(new_addr));
>  
> @@ -701,7 +701,7 @@ abi_long target_mremap(abi_ulong old_addr, abi_ulong 
> old_size,
>              host_addr = MAP_FAILED;
>          } else {
>              host_addr = (void *) syscall(__NR_mremap, g2h(old_addr),
> -                                         old_size, new_size,
> +                                         (size_t) old_size, (size_t) 
> new_size,
>                                           flags | MREMAP_FIXED,
>                                           g2h(mmap_start));
>              if (reserved_va) {
> -- 
> 2.7.3
>