[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-paramet
From: |
Marc-André Lureau |
Subject: |
Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema |
Date: |
Wed, 21 Sep 2016 16:01:08 -0400 (EDT) |
Hi
----- Original Message -----
> On 09/13/2016 08:01 AM, Marc-André Lureau wrote:
> > Signed-off-by: Marc-André Lureau <address@hidden>
> > ---
> > docs/qmp-commands.txt | 29 -----------------------------
> > qapi-schema.json | 13 +++++++++++++
> > 2 files changed, 13 insertions(+), 29 deletions(-)
> >
>
> > +++ b/qapi-schema.json
> > @@ -1011,6 +1011,19 @@
> > # Returns: @MigrationParameters
> > #
> > # Since: 2.4
> > +#
> > +# Example:
> > +#
> > +# -> { "execute": "query-migrate-parameters" }
> > +# <- { "return": {
> > +# "decompress-threads": 2,
> > +# "cpu-throttle-increment": 10,
> > +# "compress-threads": 8,
> > +# "compress-level": 1,
> > +# "cpu-throttle-initial": 20
> > +# }
> > +# }
> > +#
> > ##
> > { 'command': 'query-migrate-parameters',
> > 'returns': 'MigrationParameters' }
>
> The example lacks 'cpu-throttle-increment', 'tls-creds', and
> 'tls-hostname'; do we want to take this opportunity to touch it up?
I suggest to put a [...] in the returned example, as this example could grow
again, and there isn't much to learn from that query.
> Meanwhile, I have a series that touches this code, and will obviously
> create a merge conflict for whoever gets in second:
> https://lists.gnu.org/archive/html/qemu-devel/2016-09/msg01946.html
Yes, the more we wait to review the series, the more conflicts we will get.
There is still over 100 patches to go, I'll send the next 30.
> At any rate, 11-15 are
> Reviewed-by: Eric Blake <address@hidden>
thanks
- [Qemu-devel] [PATCH 08/30] qmp-commands: move 'ringbuf-write' doc to schema, (continued)
- [Qemu-devel] [PATCH 08/30] qmp-commands: move 'ringbuf-write' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 09/30] qmp-commands: move 'ringbuf-read' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 11/30] qmp-commands: move 'query-migrate' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 10/30] qmp-commands: move 'query-events' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 12/30] qmp-commands: move 'migrate-set-capabilities' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 13/30] qmp-commands: move 'query-migrate-capabilities' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 14/30] qmp-commands: move 'migrate-set-parameters' doc to schema, Marc-André Lureau, 2016/09/13
- [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Marc-André Lureau, 2016/09/13
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Eric Blake, 2016/09/21
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema,
Marc-André Lureau <=
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Markus Armbruster, 2016/09/22
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Marc-André Lureau, 2016/09/22
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Markus Armbruster, 2016/09/22
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Marc-André Lureau, 2016/09/22
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Markus Armbruster, 2016/09/22
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Marc-André Lureau, 2016/09/22
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Markus Armbruster, 2016/09/23
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Marc-André Lureau, 2016/09/23
- Re: [Qemu-devel] [PATCH 15/30] qmp-commands: move 'query-migrate-parameters' doc to schema, Eric Blake, 2016/09/22
[Qemu-devel] [PATCH 16/30] qmp-commands: move 'client_migrate_info' doc to schema, Marc-André Lureau, 2016/09/13