|
From: | Richard Henderson |
Subject: | Re: [Qemu-devel] [PATCH 5/6] target-i386: Automatically set level/xlevel/xlevel2 when needed |
Date: | Wed, 21 Sep 2016 12:53:08 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/21/2016 11:26 AM, Eduardo Habkost wrote:
+ /* Set cpuid_*level* based on cpuid_min_*level, if not explicitly set */ + if (!env->cpuid_level) { + env->cpuid_level = env->cpuid_min_level; + } + if (!env->cpuid_xlevel) { + env->cpuid_xlevel = env->cpuid_min_xlevel; + } + if (!env->cpuid_xlevel2) { + env->cpuid_xlevel2 = env->cpuid_min_xlevel2; }
Why are we not bounding them by MIN, if it's really a minimum?
+ /* Enable auto level-increase for CPUID[7].ECX features */ + bool cpuid_auto_level_7_0_ecx; + + /* Enable auto level-increase for CPUID[6] features */ + bool cpuid_auto_level_6;
Why two variables? Seems like only one is needed for backward compatibility. You're not considering adding a new one when cpuid[8].ebx is invented are you?
r~
[Prev in Thread] | Current Thread | [Next in Thread] |