qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result


From: Eric Blake
Subject: Re: [Qemu-devel] [PATCH] replay: Fix build with -Werror=unused-result
Date: Wed, 21 Sep 2016 13:18:58 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0

On 09/21/2016 10:28 AM, Markus Armbruster wrote:

>> The compiler.h file has no license header, just a comment
>> saying "public domain", which is obviously not the case
>> if you add this macro.
>>
>> Given that you'll need to explicitly mention the license terms
>> for ignore_value. eg with a comment line like
>>
>>   /* The ignore_value() macro is taken from GNULIB ignore-value.h,
>>    * licensed under the terms of the LGPLv2+
>>    */
> 
> Our tree has a mix of licenses, which is enough of a pain.  Mixing
> licenses within *files* is even worse, and might not even be legally
> sound.
> 
> Relicense the whole file under our preferred license GPLv2+?

That works too.  No one can legally complain - the current license is so
permissive that marking the entire file LGPLv2+ is permitted by the
current license.  It's a one-way conversion (we can't go back once we do
it), but I would be fine with that approach.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]