[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 7/7] virtio-scsi: handle virtio_scsi_set_config() er
From: |
Greg Kurz |
Subject: |
[Qemu-devel] [PATCH 7/7] virtio-scsi: handle virtio_scsi_set_config() error |
Date: |
Wed, 21 Sep 2016 15:14:49 +0200 |
User-agent: |
StGit/0.17.1-dirty |
This error is caused by a buggy guest: let's switch the device to the
broken state instead of terminating QEMU.
Signed-off-by: Greg Kurz <address@hidden>
---
hw/scsi/virtio-scsi.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/scsi/virtio-scsi.c b/hw/scsi/virtio-scsi.c
index d475d5e40d91..592b6fd72359 100644
--- a/hw/scsi/virtio-scsi.c
+++ b/hw/scsi/virtio-scsi.c
@@ -628,8 +628,9 @@ static void virtio_scsi_set_config(VirtIODevice *vdev,
if ((uint32_t) virtio_ldl_p(vdev, &scsiconf->sense_size) >= 65536 ||
(uint32_t) virtio_ldl_p(vdev, &scsiconf->cdb_size) >= 256) {
- error_report("bad data written to virtio-scsi configuration space");
- exit(1);
+ virtio_error(vdev,
+ "bad data written to virtio-scsi configuration space");
+ return;
}
vs->sense_size = virtio_ldl_p(vdev, &scsiconf->sense_size);
- [Qemu-devel] [PATCH 2/7] virtio-blk: handle virtio_blk_handle_request() errors, (continued)
- [Qemu-devel] [PATCH 2/7] virtio-blk: handle virtio_blk_handle_request() errors, Greg Kurz, 2016/09/21
- [Qemu-devel] [PATCH 3/7] virtio-net: handle virtio_net_handle_ctrl() error, Greg Kurz, 2016/09/21
- [Qemu-devel] [PATCH 4/7] virtio-net: handle virtio_net_receive() errors, Greg Kurz, 2016/09/21
- [Qemu-devel] [PATCH 5/7] virtio-net: handle virtio_net_flush_tx() errors, Greg Kurz, 2016/09/21
- [Qemu-devel] [PATCH 6/7] virtio-scsi: convert virtio_scsi_bad_req() to use virtio_error(), Greg Kurz, 2016/09/21
- [Qemu-devel] [PATCH 7/7] virtio-scsi: handle virtio_scsi_set_config() error,
Greg Kurz <=
- Re: [Qemu-devel] [PATCH 0/7] virtio: avoid inappropriate QEMU termination, no-reply, 2016/09/21
- Re: [Qemu-devel] [PATCH 0/7] virtio: avoid inappropriate QEMU termination, Michael S. Tsirkin, 2016/09/21
- Re: [Qemu-devel] [PATCH 0/7] virtio: avoid inappropriate QEMU termination, Greg Kurz, 2016/09/21
Re: [Qemu-devel] [PATCH 0/7] virtio: avoid inappropriate QEMU termination, Gonglei, 2016/09/21