[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and SIGHUP |
Date: |
Wed, 21 Sep 2016 09:42:43 +0100 |
User-agent: |
Mutt/1.7.0 (2016-08-17) |
On Wed, Sep 21, 2016 at 11:49:27AM +0800, Fam Zheng wrote:
> Signed-off-by: Fam Zheng <address@hidden>
> ---
> tests/docker/docker.py | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/tests/docker/docker.py b/tests/docker/docker.py
> index b85c165..552608e 100755
> --- a/tests/docker/docker.py
> +++ b/tests/docker/docker.py
> @@ -21,6 +21,7 @@ import uuid
> import argparse
> import tempfile
> import re
> +import signal
> from tarfile import TarFile, TarInfo
> from StringIO import StringIO
> from shutil import copy, rmtree
> @@ -98,6 +99,8 @@ class Docker(object):
> self._command = _guess_docker_command()
> self._instances = []
> atexit.register(self._kill_instances)
> + signal.signal(signal.SIGTERM, self._kill_instances)
> + signal.signal(signal.SIGHUP, self._kill_instances)
>
> def _do(self, cmd, quiet=True, infile=None, **kwargs):
> if quiet:
> @@ -130,7 +133,7 @@ class Docker(object):
> self._do_kill_instances(False, False)
> return 0
>
> - def _kill_instances(self):
> + def _kill_instances(self, *args, **kwargs):
> return self._do_kill_instances(True)
>
> def _output(self, cmd, **kwargs):
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
- Re: [Qemu-devel] [PATCH 3/9] docker: Generate /packages.txt in ubuntu image, (continued)
- [Qemu-devel] [PATCH 4/9] docker: Update fedora image to latest, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 5/9] docker: Flatten default target list in test-quick, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 6/9] docker: Print used options before doing configure, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 7/9] docker: Support showing environment information, Fam Zheng, 2016/09/20
- [Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and SIGHUP, Fam Zheng, 2016/09/20
- Re: [Qemu-devel] [PATCH 8/9] docker: Terminate instances at SIGTERM and SIGHUP,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH 9/9] docker: exec $CMD, Fam Zheng, 2016/09/20