|
| From: | Richard Henderson |
| Subject: | Re: [Qemu-devel] [PATCH RFC v1 28/29] target-arc: decode |
| Date: | Tue, 20 Sep 2016 17:49:13 -0700 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/08/2016 03:32 PM, Michael Rolnik wrote:
+ decode_f decode[32] = {
There's no reason to use an array here, and worse, a non-static non-const array. Just use a switch here
+ return decode[curr_major](ctx, curr_opcode);
r~
| [Prev in Thread] | Current Thread | [Next in Thread] |