Re: [Qemu-devel] [PATCH v2 10/11] qemu-iotests/141: Avoid blockdev-add with id

[Eric Blake]

On 09/20/2016 08:03 AM, Kevin Wolf wrote:
> We want to remove the 'id' option for blockdev-add. This removes one
> user of the option and makes it use only node names.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/141     | 24 ++++++++++++++----------
>  tests/qemu-iotests/141.out | 24 ++++++++++++------------
>  2 files changed, 26 insertions(+), 22 deletions(-)
> 

> +++ b/tests/qemu-iotests/141.out
> @@ -9,30 +9,30 @@ Formatting 'TEST_DIR/t.IMGFMT', fmt=IMGFMT size=1048576 
> backing_file=TEST_DIR/m.
>  {"return": {}}
>  Formatting 'TEST_DIR/o.IMGFMT', fmt=IMGFMT size=1048576 
> backing_file=TEST_DIR/t.IMGFMT backing_fmt=IMGFMT
>  {"return": {}}
> -{"error": {"class": "GenericError", "desc": "Node 'drv0' is busy: block 
> device is in use by block job: backup"}}
> +{"error": {"class": "GenericError", "desc": "Node drv0 is in use by (null)"}}

Are we calling printf("%s",NULL) (not portable) or
printf("%s","(null)")?  At any rate, is the poorer error message quality
intentional? I'd feel more comfortable if we knew why the error message
regressed, before giving R-b here.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature