Re: [Qemu-devel] [PATCH v2 08/11] qemu-iotests/124: Avoid blockdev-add with id

[Eric Blake]

On 09/20/2016 08:03 AM, Kevin Wolf wrote:
> We want to remove the 'id' option for blockdev-add. This removes one
> user of the option and makes it use only node names.
> 
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/124 | 17 ++++++++++-------
>  1 file changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/qemu-iotests/124 b/tests/qemu-iotests/124
> index de7cdbe..33525bf 100644
> --- a/tests/qemu-iotests/124
> +++ b/tests/qemu-iotests/124
> @@ -49,8 +49,8 @@ def transaction_bitmap_clear(node, name, **kwargs):
>  
>  
>  def transaction_drive_backup(device, target, **kwargs):
> -    return transaction_action('drive-backup', device=device, target=target,
> -                              **kwargs)
> +    return transaction_action('drive-backup', job_id= device, device=device,

Umm, why the whitespace after =?

pep8 already complains about this (and other) pythonic iotests, but no
need to make it noisier :)

With that fixed,
Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature