Re: [Qemu-devel] [libvirt] [PATCH v3 4/5] qmp: Add runnability information to query-cpu-definitions

[Eric Blake]

On 09/19/2016 02:42 PM, Eduardo Habkost wrote:
> Add a new optional field to query-cpu-definitions schema:
> "unavailable-features". It will contain a list of QOM properties
> that prevent the CPU model from running in the current host.
> 
> Cc: David Hildenbrand <address@hidden>
> Cc: Michael Mueller <address@hidden>
> Cc: Christian Borntraeger <address@hidden>
> Cc: Cornelia Huck <address@hidden>
> Cc: Jiri Denemark <address@hidden>
> Cc: address@hidden
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---

> +++ b/qapi-schema.json
> @@ -3111,10 +3111,31 @@
>  #          QEMU version, machine type, machine options and accelerator 
> options.
>  #          A static model is always migration-safe. (since 2.8)
>  #
> +# @unavailable-features: #optional List of properties that prevent
> +#                        the CPU model from running in the current
> +#                        host. (since 2.7)

We've missed 2.7; this should probably be 2.8.  Otherwise reads okay to me;

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature