Re: [Qemu-devel] [PATCH 02/30] qmp-commands: move 'query-name' doc to schema

[Eric Blake]

On 09/13/2016 08:01 AM, Marc-André Lureau wrote:
> Signed-off-by: Marc-André Lureau <address@hidden>
> ---
>  docs/qmp-commands.txt | 14 --------------
>  qapi-schema.json      | 12 +++++++++---
>  2 files changed, 9 insertions(+), 17 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -102,9 +102,9 @@
>  #
>  # Guest name information.
>  #
> -# @name: #optional The name of the guest
> +# @name: #optional the name of the guest
>  #
> -# Since 0.14.0
> +# Since: 0.14.0

You are doing more than just moving documentation; you are also
normalizing how the existing documentation is presented. Might be worth
mentioning that in various commit messages along the series, or to
rebase things to do the cleanups (uncontroversially safe to do now)
separately from the doc motion (motion is easier to review when there
are no other changes thrown in the mix, and we already know that we are
at risk of merge conflicts causing either you or other developers some
rebase churn, where we have to be careful we don't lose contents).

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature