Re: [Qemu-devel] [PATCH] Add resolutions via the command-line

[G 3]

On Sep 19, 2016, at 6:44 PM, Benjamin Herrenschmidt wrote:

> On Mon, 2016-09-19 at 08:44 -0400, G 3 wrote:
> > On Sep 19, 2016, at 2:24 AM, Benjamin Herrenschmidt wrote:
> >
> > > On Sat, 2016-09-17 at 23:31 -0400, G 3 wrote:
> > > > Add the ability to add resolutions from the command-line. This
> > > > patch
> > > > works by
> > > > looking for a property called 'resolutions' in the options node
> > > > of
> > > > OpenBIOS.
> > > > If it is found all the resolutions are parsed and loaded.
> > > >
> > > > Example command-line:
> > >
> > > You must not use the C library in the ndrv (malloc, atoi, ...)
> > >
> > > Stick to what's in DriverServicesLib and NameRegistryLib.
> >
> > I originally thought that, but was wrong. Those C library functions
> > work.
>
> No, don't use them. They "seem" to work but bad thing will happen,
> especially on OS X.
>
> Cheers,
> Ben.

Ok, they have been replaced in my next patch.

Something is wrong with the options node in OpenBIOS. It is  
inaccessible from Mac OS X. When trying to access the options node,  
IORegistryExplorer always crashes. The other nodes are accessible.  
I'm not certain what the problem could be.