Re: [Qemu-devel] [PATCH v3 0/6] Clean up TCG tests

[Marc-André Lureau]

Hi Pranith

On Sat, Sep 17, 2016 at 6:05 PM Pranith Kumar <address@hidden> wrote:

> Hello,
>
> This patch series cleans up the tcg tests in tests/tcg folder.
>
>
Incidentally, I was also looking at reorganizing tests/tcg last week. I
think your series brings some necessary improvements, but it will probably
need more iterations before it is accepted. Could you split off your
obvious changes, such as test build fixes? I think it would help to get
those out of the way first (cc -trivial). Also it would help if you
documented the makefile changes.


> The tests have bit-rotten and were not compiling or running. I fixed
> the Makefiles to make them compile but there are tests which do not
> pass.
>
> The motivation is to add litmus tests to each arch and have them run
> using the 'make check' target to test consistency on TCG.
>
> There are no maintainers listed for this test folder. So I am cc'ing
> people who I think might be interested.
>
> As suggested by rth in v1 posting, I hooked up 'tests-tcg' target to
> run native tests. Detecting cross compilers or running the tests
> in docker containers are suggested ideas to make running the tests
> easier.
>

It doesn't make much sense to me to run only native tests (the uname -p),
could you explain the rationale? Instead, I would check what
cross-compilers and qemu targets are available to run the appropriate tests.


>
> v3:
>   - Update with review feedback from Alex Bennée.
>
> v2:
>   - Add tests-tcg target to invoke native tests.
>
> Pranith Kumar (6):
>   tests/tcg: Move i386 tests to arch specific folder
>   tests/tcg: Move arm tests to arch specific folder
>   tests/tcg: Move mips test to arch specific folder
>   tests/tcg: Create and populate misc tests for arch independent tests
>   tests/tcg: Add and update Makefiles
>   tests/tcg: Add tests-tcg hook in Makefile
>
>  tests/Makefile.include                  |   1 +
>  tests/tcg/Makefile                      | 156
> --------------------------------
>  tests/tcg/Makefile.include              |  34 +++++++
>  tests/tcg/alpha/Makefile                |  38 +++++---
>  tests/tcg/arm/Makefile                  |  51 +++++++++++
>  tests/tcg/{ => arm}/hello-arm.c         |   0
>  tests/tcg/{ => arm}/test-arm-iwmmxt.s   |   0
>  tests/tcg/cris/Makefile                 |  17 +++-
>  tests/tcg/i386/Makefile                 |  87 ++++++++++++++++++
>  tests/tcg/{ => i386}/hello-i386.c       |   9 +-
>  tests/tcg/{ => i386}/pi_10.com          | Bin
>  tests/tcg/{ => i386}/runcom.c           |   0
>  tests/tcg/{ => i386}/test-i386-code16.S |   0
>  tests/tcg/{ => i386}/test-i386-fprem.c  |   0
>  tests/tcg/{ => i386}/test-i386-muldiv.h |   0
>  tests/tcg/{ => i386}/test-i386-shift.h  |   0
>  tests/tcg/{ => i386}/test-i386-ssse3.c  |   0
>  tests/tcg/{ => i386}/test-i386-vm86.S   |   0
>  tests/tcg/{ => i386}/test-i386.c        |   0
>  tests/tcg/{ => i386}/test-i386.h        |   0
>  tests/tcg/lm32/Makefile                 |  17 +++-
>  tests/tcg/mips/Makefile                 |  46 ++++++++++
>  tests/tcg/{ => mips}/hello-mips.c       |   0
>  tests/tcg/mips/mips32-dsp/Makefile      |  17 +++-
>  tests/tcg/mips/mips32-dspr2/Makefile    |  17 +++-
>  tests/tcg/mips/mips64-dsp/Makefile      |  18 +++-
>  tests/tcg/mips/mips64-dspr2/Makefile    |  17 +++-
>  tests/tcg/misc/Makefile                 |  81 +++++++++++++++++
>  tests/tcg/{ => misc}/linux-test.c       |   3 +
>  tests/tcg/{ => misc}/sha1.c             |   0
>  tests/tcg/{ => misc}/test-mmap.c        |   0
>  tests/tcg/{ => misc}/test_path.c        |   0
>  tests/tcg/{ => misc}/testthread.c       |   0
>  tests/tcg/openrisc/Makefile             |  19 +++-
>  tests/tcg/xtensa/Makefile               |  17 +++-
>  35 files changed, 457 insertions(+), 188 deletions(-)
>  delete mode 100644 tests/tcg/Makefile
>  create mode 100644 tests/tcg/Makefile.include
>  create mode 100644 tests/tcg/arm/Makefile
>  rename tests/tcg/{ => arm}/hello-arm.c (100%)
>  rename tests/tcg/{ => arm}/test-arm-iwmmxt.s (100%)
>  create mode 100644 tests/tcg/i386/Makefile
>  rename tests/tcg/{ => i386}/hello-i386.c (71%)
>  rename tests/tcg/{ => i386}/pi_10.com (100%)
>  rename tests/tcg/{ => i386}/runcom.c (100%)
>  rename tests/tcg/{ => i386}/test-i386-code16.S (100%)
>  rename tests/tcg/{ => i386}/test-i386-fprem.c (100%)
>  rename tests/tcg/{ => i386}/test-i386-muldiv.h (100%)
>  rename tests/tcg/{ => i386}/test-i386-shift.h (100%)
>  rename tests/tcg/{ => i386}/test-i386-ssse3.c (100%)
>  rename tests/tcg/{ => i386}/test-i386-vm86.S (100%)
>  rename tests/tcg/{ => i386}/test-i386.c (100%)
>  rename tests/tcg/{ => i386}/test-i386.h (100%)
>  create mode 100644 tests/tcg/mips/Makefile
>  rename tests/tcg/{ => mips}/hello-mips.c (100%)
>  create mode 100644 tests/tcg/misc/Makefile
>  rename tests/tcg/{ => misc}/linux-test.c (99%)
>  rename tests/tcg/{ => misc}/sha1.c (100%)
>  rename tests/tcg/{ => misc}/test-mmap.c (100%)
>  rename tests/tcg/{ => misc}/test_path.c (100%)
>  rename tests/tcg/{ => misc}/testthread.c (100%)
>
> --
> 2.9.3
>
>
> --
Marc-André Lureau