Re: [Qemu-devel] [PATCH v5 8/8] linux-user: Remove a duplicate item from strace.list

[Laurent Vivier]

Le 14/09/2016 à 22:20, Aleksandar Markovic a écrit :
> From: Aleksandar Markovic <address@hidden>
> 
> There is a duplicate item in strace.list. It is benign, but it
> shouldn't be there. It is the only duplicate in strace.list. This
> patch removes it.
> 
> Signed-off-by: Aleksandar Markovic <address@hidden>
> ---
>  linux-user/strace.list | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/linux-user/strace.list b/linux-user/strace.list
> index 2f99ac2..f74545f 100644
> --- a/linux-user/strace.list
> +++ b/linux-user/strace.list
> @@ -1532,9 +1532,6 @@
>  #ifdef TARGET_NR_utimensat
>  { TARGET_NR_utimensat, "utimensat", NULL, print_utimensat, NULL },
>  #endif
> -#ifdef TARGET_NR_sync_file_range
> -{ TARGET_NR_sync_file_range, "sync_file_range", NULL, NULL, NULL },
> -#endif
>  #ifdef TARGET_NR_sync_file_range2
>  { TARGET_NR_sync_file_range2, "sync_file_range2", NULL, NULL, NULL },
>  #endif
> 


You should remove the other one, as this one has been added when the
syscall has been implemented:

c727f47 linux-user: Implement sync_file_range{,2} syscalls

Laurent