Re: [Qemu-devel] [PATCH v5 1/8] linux-user: Add support for adjtimex() syscall

[Laurent Vivier]

Le 17/09/2016 à 20:40, Laurent Vivier a écrit :
> 
> 
> Le 14/09/2016 à 22:19, Aleksandar Markovic a écrit :

>>  static inline abi_long target_to_host_timespec(struct timespec *host_ts,
>>                                                 abi_ulong target_addr)
>>  {
>> @@ -9419,8 +9492,23 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
>> arg1,
>>          break;
>>  #endif
>>  #endif
>> +#ifdef TARGET_NR_adjtimex
>>      case TARGET_NR_adjtimex:
>> -        goto unimplemented;
>> +        {
>> +            struct timex host_buf;
>> +
> 
> check arg1 != NULL, so you manage target_to_host and host_to_target NULL
> case.

In fact, I think you should not check that, it will be managed by
lock_user_struct().

Laurent