Re: [Qemu-devel] [PATCH 00/26] trivial: use exit(EXIT_SUCCESS) and exit(EXIT_FAILURE)

[Daniel P. Berrange]

On Fri, Sep 16, 2016 at 03:55:51PM +0200, Laurent Vivier wrote:
> This series is the result of coccinelle patch
> scripts/coccinelle/exit.cocci
> provided by the first patch of the series.
> 
> It replaces exit(0) by exit(EXIT_SUCCESS)
> and exit(1) by exit(EXIT_FAILURE).

Some places use '_exit' and should have had the same
change applied AFAICT.

> All other exit() are not modified as we don't want
> to change the behavior.

IMHO, modifying the other exit() calls is precisely
what would make this series useful.

eg there's a bunch of places which arbitrarily use
'-1' instead of '1' as the value for no good reason.

Consolidating the inconsistent use of -1 and 1 would
have functional benefit.

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|