Re: [Qemu-devel] [PATCH 0/5] spapr: convert SPAPR devices to trace framework

[Laurent Vivier]

On 16/09/2016 05:04, David Gibson wrote:
> On Thu, Sep 15, 2016 at 10:09:34AM +1000, David Gibson wrote:
>> On Wed, Sep 14, 2016 at 08:48:22PM +0200, Laurent Vivier wrote:
>>> Define and use trace_spapr_XXX functions instead of
>>> DPRINTF to trace some SPAPR devices: spapr_vio, spapr_drc, spapr_rtas,
>>> spapr_llan, spapr_vscsi.
>>>
>>> This allows to enable dynamically (instead of recompiling the source)
>>> the traces for these devices. Messages are close as possible as
>>> messages used by DPRINTF. Sometime, I've removed some text to
>>> avoid redundancy between information given by the tracing function name
>>> and the text displayed. I've also updated print format to use
>>> the good conversion specifier ('u' instead of 'd' when the type is unsigned,
>>> PRIx32 instead of 'x' when the type is uint32_t or int32_t, ...)
>>
>> I've removed the blank likes that Eric Blake mentioned, and applied to
>> ppc-for-2.8.
> 
> Sorry, I've taken 5/5 the vscsi one out again.  It breaks compile with
> --enable-trace-backend=ust, and I haven't had a chance to debug it so far.
> 

It seems one function has too many arguments for this backend.

I'll re-post the series with only this change in the patch 5/5.

Thanks,
Laurent