Re: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

[no-reply]

Hi,

Your series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PULL v2 0/6] virtio,pci: fixes and updates

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

# Useful git options
git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git show --no-patch --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
6e5404e MAINTAINERS: add virtio-* tests
891e449 hw/i386: AMD IOMMU IVRS table
2e128a0 hw/i386: Introduce AMD IOMMU
6f5a9ae hw/i386/trace-events: Add AMD IOMMU trace events
1ee8f53 hw/pci: Prepare for AMD IOMMU
aa2f6bf virtio-bus: Plug devices after features are negotiated

=== OUTPUT BEGIN ===
Checking PATCH 1/6: virtio-bus: Plug devices after features are negotiated...
Checking PATCH 2/6: hw/pci: Prepare for AMD IOMMU...
Checking PATCH 3/6: hw/i386/trace-events: Add AMD IOMMU trace events...
Checking PATCH 4/6: hw/i386: Introduce AMD IOMMU...
ERROR: struct MemoryRegionIOMMUOps should normally be const
#1707: FILE: hw/i386/amd_iommu.h:280:
+    MemoryRegionIOMMUOps iommu_ops;

total: 1 errors, 0 warnings, 1677 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 5/6: hw/i386: AMD IOMMU IVRS table...
Checking PATCH 6/6: MAINTAINERS: add virtio-* tests...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden