Re: [Qemu-devel] [PATCH v4 0/3] block: Fix libbz2 library dependency regresssion

[Fam Zheng]

On Wed, 09/14 16:48, Max Reitz wrote:
> On 2016-09-14 at 16:35, Stefan Hajnoczi wrote:
> > On Mon, Sep 05, 2016 at 10:50:42AM +0800, Fam Zheng wrote:
> > > v4: Remove unused variable in patch 1 and unwanted warning in patch 2. 
> > > [Max]
> > > 
> > > v3: Fix typo in copyright header. [Max]
> > >     Fix pre-existing type casting. [Max]
> > > 
> > > v2: Rebase on top of Max's block-next tree, which has Colin's patches to
> > >     dynamically load block modules.
> > >     Two more tweaks to the module system is added.
> > > 
> > > v1 was submitted as a single patch:
> > > 
> > > https://lists.gnu.org/archive/html/qemu-devel/2016-08/msg00508.html
> > > 
> > > Fam Zheng (3):
> > >   scripts: Allow block module to not define BlockDriver
> > >   module: Don't load the same module if requested multiple times
> > >   dmg: Move libbz2 code to dmg-bz2.so
> > > 
> > >  block/Makefile.objs             |  3 +-
> > >  block/dmg-bz2.c                 | 62 ++++++++++++++++++++++++++++++++++++
> > >  block/dmg.c                     | 69 
> > > ++++++++++-------------------------------
> > >  block/dmg.h                     | 59 +++++++++++++++++++++++++++++++++++
> > >  scripts/modules/module_block.py |  7 -----
> > >  util/module.c                   | 18 +++++++++--
> > >  6 files changed, 156 insertions(+), 62 deletions(-)
> > >  create mode 100644 block/dmg-bz2.c
> > >  create mode 100644 block/dmg.h
> > 
> > Max was the last one to comment on this series.  I'll wait for him to
> > review this before applying it.
> 
> Looks good to me, but I'm afraid this series might depend on my block-next
> (now block) branch which has not been merged to master yet, actually. So
> maybe I should apply it instead? ;-)

Yes, please!

Fam