[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop()
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine |
Date: |
Wed, 14 Sep 2016 16:40:48 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/14/2016 04:33 PM, Cédric Le Goater wrote:
> On 09/14/2016 03:59 PM, Alex Bennée wrote:
>>
>> David Gibson <address@hidden> writes:
>>
>>> From: Cédric Le Goater <address@hidden>
>>>
>>> The exact same routine will be used in PowerNV.
>>>
>>> Signed-off-by: Cédric Le Goater <address@hidden>
>>> Signed-off-by: David Gibson <address@hidden>
>>
>> This patch has broken 32 bit x86 builds on CentOS6 (I happened to be looking
>> at something else and found it broken):
>>
>> 14:57 address@hidden/i686 [qemu.git/bisect:???] >make
>> CC ppc-softmmu/hw/ppc/fdt.o
>> In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14:
>> /home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefinition of
>> typedef ‘CPUPPCState’
>> /home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous
>> declaration of ‘CPUPPCState’ was here
>> make[1]: *** [hw/ppc/fdt.o] Error 1
>> make: *** [subdir-ppc-softmmu] Error 2
>
> ok. CentOS6 must be 4.4 compiler, which has that kind of problem.
>
> Could you try that quick fix ?
Nah, Paolo did it already :)
Thanks !
C.
- [Qemu-devel] [PULL 09/64] target-ppc: add cnttzd[.] instruction, (continued)
- [Qemu-devel] [PULL 09/64] target-ppc: add cnttzd[.] instruction, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 25/64] ppc: Don't update the NIP in floating point generated code, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 23/64] ppc: Make float_invalid_op_excp() pass the return address, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 31/64] ppc: Don't update NIP in DCR access routines, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 38/64] ppc: Handle unconditional (always/never) traps at translation time, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 48/64] target-ppc: add vcmpnez[b, h, w][.] instructions, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 60/64] ppc: Improve the exception helpers flags, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 43/64] ppc: load/store multiple and string insns don't do LE, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 47/64] target-ppc: add vabsdu[b, h, w] instructions, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 42/64] ppc: Use a helper to generate "LE unsupported" alignment interrupts, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 49/64] target-ppc: add vslv instruction, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 24/64] ppc: Make float_check_status() pass the return address, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 29/64] ppc: Make tlb_fill() use new exception helper, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 51/64] target-ppc: add extswsli[.] instruction, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 53/64] hw/ppc: use error_report instead of fprintf, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 41/64] ppc: Don't set access_type on all load/stores on hash64, David Gibson, 2016/09/07
- [Qemu-devel] [PULL 39/64] ppc: Speed up dcbz, David Gibson, 2016/09/07