[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v11 2/6] option: make parse_option_bool/number n
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH v11 2/6] option: make parse_option_bool/number non-static |
|
Date: |
Wed, 14 Sep 2016 16:33:25 +0200 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
Am 05.09.2016 um 17:16 hat Daniel P. Berrange geschrieben:
> The opts-visitor.c opts_type_bool() method has code for
> parsing a string to set a bool value, as does the
> qemu-option.c parse_option_bool() method, except it
> handles fewer cases.
>
> To enable consistency across the codebase, extend
> parse_option_bool() to handle "yes", "no", "y" and
> "n", and make it non-static. Convert the opts
> visitor to call this method directly.
>
> Also make parse_option_number() non-static to allow
> for similar reuse later.
>
> Reviewed-by: Marc-André Lureau <address@hidden>
> Reviewed-by: Eric Blake <address@hidden>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Daniel P. Berrange <address@hidden>
Reviewed-by: Kevin Wolf <address@hidden>
- [Qemu-devel] [PATCH v11 0/6] QAPI/QOM work for non-scalar object properties, Daniel P. Berrange, 2016/09/05
- [Qemu-devel] [PATCH v11 2/6] option: make parse_option_bool/number non-static, Daniel P. Berrange, 2016/09/05
- Re: [Qemu-devel] [PATCH v11 2/6] option: make parse_option_bool/number non-static,
Kevin Wolf <=
- [Qemu-devel] [PATCH v11 1/6] qdict: implement a qdict_crumple method for un-flattening a dict, Daniel P. Berrange, 2016/09/05
- [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion, Daniel P. Berrange, 2016/09/05
- Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion, Eric Blake, 2016/09/12
- Re: [Qemu-devel] [PATCH v11 5/6] qapi: add a QmpInputVisitor that does string conversion, Markus Armbruster, 2016/09/13