[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] memory: remove memory_region_destructor_rom_dev
From: |
Igor Mammedov |
Subject: |
Re: [Qemu-devel] [PATCH] memory: remove memory_region_destructor_rom_device |
Date: |
Wed, 14 Sep 2016 12:08:07 +0200 |
On Wed, 14 Sep 2016 11:06:34 +0200
Paolo Bonzini <address@hidden> wrote:
> It is equivalent to memory_region_destructor_ram, use that one.
>
> Signed-off-by: Paolo Bonzini <address@hidden>
Reviewed-by: Igor Mammedov <address@hidden>
> ---
> memory.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/memory.c b/memory.c
> index 0eb6895..5ed3872 100644
> --- a/memory.c
> +++ b/memory.c
> @@ -943,10 +943,6 @@ static void memory_region_destructor_ram(MemoryRegion
> *mr)
> {
> qemu_ram_free(mr->ram_block);
> }
> -
> -static void memory_region_destructor_rom_device(MemoryRegion *mr)
> -{
> - qemu_ram_free(mr->ram_block);
> }
>
> static bool memory_region_need_escape(char c)
> @@ -1405,7 +1401,7 @@ void memory_region_init_rom_device(MemoryRegion *mr,
> mr->opaque = opaque;
> mr->terminates = true;
> mr->rom_device = true;
> - mr->destructor = memory_region_destructor_rom_device;
> + mr->destructor = memory_region_destructor_ram;
> mr->ram_block = qemu_ram_alloc(size, mr, errp);
> }
>