Re: [Qemu-devel] [PATCH qemu v2] tap: Allow specifying a bridge

[Alexey Kardashevskiy]

On 14/09/16 01:39, Greg Kurz wrote:
> On Tue, 13 Sep 2016 09:49:09 -0500
> Eric Blake <address@hidden> wrote:
> 
>> On 09/13/2016 02:11 AM, Alexey Kardashevskiy wrote:
>>> The tap backend is already using qemu-bridge-helper to attach tap
>>> interface to a bridge but (unlike the bridge backend) it always uses
>>> the default bridge name - br0.
>>>
>>> This adds a "br" property support to the tap backend.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <address@hidden>
>>> --
>>> Changes:
>>> v2:
>>> * documented a new member in json and hx
>>> ---
>>>  net/tap.c        |  4 +++-
>>>  qapi-schema.json |  3 +++
>>>  qemu-options.hx  | 12 +++++++-----
>>>  3 files changed, 13 insertions(+), 6 deletions(-)
>>>   
>>
>>> +++ b/qapi-schema.json
>>> @@ -2575,6 +2575,8 @@
>>>  #
>>>  # @downscript: #optional script to shut down the interface
>>>  #
>>> +# @br: #optional bridge name  
>>
>> Missing a '(since 2.8)' designator.
>>
>> Also, we don't have to abbreviate; 'bridge-name' may be easier to
>> understand than 'br', as well as a mention of the default value if the
>> parameter is not supplied.


The existing NetdevBridgeOptions does not do this in json as well and it
does in qemu-options.hx, so does my patch. Do I have to fix a bridge first
before reposting this patch?...

When exactly is the content of qapi-schema.json's comments shown to a user?


>>
> 
> FWIW @br is consistent with what we already have in NetdevBridgeOptions
> since 1.2.

Right, this is why "br=".


-- 
Alexey

signature.asc
Description: OpenPGP digital signature