Re: [Qemu-devel] [RFC PATCH v1 04/22] memattrs: add SEV debug attrs

[Paolo Bonzini]

On 13/09/2016 16:47, Brijesh Singh wrote:
> The patch adds sev_debug_mode attribute in MemTxAttrs. This attribute
> will be set when debug version of memory read/write API's are used in
> SEV-enabled guest.
> 
> Signed-off-by: Brijesh Singh <address@hidden>
> ---
>  include/exec/memattrs.h |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/include/exec/memattrs.h b/include/exec/memattrs.h
> index e601061..5aa22b5 100644
> --- a/include/exec/memattrs.h
> +++ b/include/exec/memattrs.h
> @@ -37,6 +37,8 @@ typedef struct MemTxAttrs {
>      unsigned int user:1;
>      /* Requester ID (for MSI for example) */
>      unsigned int requester_id:16;
> +    /* Memory access for debug purposes */
> +    unsigned int sev_debug:1;
>  } MemTxAttrs;
>  
>  /* Bus masters which don't specify any attributes will get this,
> @@ -46,4 +48,6 @@ typedef struct MemTxAttrs {
>   */
>  #define MEMTXATTRS_UNSPECIFIED ((MemTxAttrs) { .unspecified = 1 })
>  
> +/* Access the guest memory for debug purposes */
> +#define MEMTXATTRS_SEV_DEBUG ((MemTxAttrs) { .sev_debug = 1 })
>  #endif

Just make it "debug" and MEMTXATTRS_DEBUG.

Paolo