Re: [Qemu-devel] [PATCH] qcow2: avoid memcpy(dst, NULL, len)

[Eric Blake]

On 09/13/2016 04:15 AM, Stefan Hajnoczi wrote:
> Section "7.1.4 Use of library functions" in the C99 standard says:
> 
>   If an argument to a function has an invalid value (such as [...]
>   a null pointer [...]) [...] the behavior is undefined.
> 
> Additionally the "searching and sorting" functions are specified as
> requiring valid pointer values as described in 7.1.4.
> 
> This patch fixes the following static analyzer errors:
> 
>   block/qcow2.c:1807:41: runtime error: null pointer passed as argument 2, 
> which is declared to never be null
>   block/qcow2-cluster.c:86:26: runtime error: null pointer passed as argument 
> 2, which is declared to never be null
> 
> Reported-by: Peter Maydell <address@hidden>
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  block/qcow2-cluster.c | 4 +++-
>  block/qcow2.c         | 5 ++++-
>  2 files changed, 7 insertions(+), 2 deletions(-)

Reviewed-by: Eric Blake <address@hidden>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

signature.asc
Description: OpenPGP digital signature