Re: [Qemu-devel] [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff

[Daniel P. Berrange]

On Tue, Sep 13, 2016 at 10:05:01AM +0000, Gonglei (Arei) wrote:
> 
> 
> > -----Original Message-----
> > From: Daniel P. Berrange [mailto:address@hidden
> > Sent: Tuesday, September 13, 2016 5:23 PM
> > To: Gonglei (Arei)
> > Cc: address@hidden; address@hidden; Huangpeng
> > (Peter); Luonengjun; address@hidden; address@hidden;
> > address@hidden; Huangweidong (C); address@hidden;
> > address@hidden; address@hidden; Claudio Fontana; address@hidden;
> > address@hidden
> > Subject: Re: [PATCH v2 03/15] crypto: add cryptoLegacyHW stuff
> > 
> > On Tue, Sep 13, 2016 at 11:52:09AM +0800, Gonglei wrote:
> > > In previous patch, we define CryptoLegacyHWOptions in
> > > qapi-schema.json. we introduce the new/delete funciton
> > > about crypto legacy hardware device.
> > 
> > Isn't virtio-crypto / cryptodev an entirely new specification ?
> 
> Yes, it's an complete new device.
> 
> > I'm surprised to be seeing something completely new described
> > as "legacy". Can you explain this in more detail.
> > 
> Because there are two kind of crypto device, one is virtio-crypto which is
> a virtual crypto device (And virtio-crypto device is a real crypto device 
> seen by the guest). 
> The other is cryptodev backend device.  I have no good idea to name the kind
> of virtio-crypto device, so named to legacy crypto device refer to Net stuff.
> 
> Do you have any suggestion? Thanks!

How about just calling it 'Backend' instead of 'Legacy' then ?

Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|