[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-co
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt |
Date: |
Tue, 13 Sep 2016 09:41:15 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Marc-André Lureau <address@hidden> writes:
> Hi
>
> On Tue, Sep 13, 2016 at 1:54 AM Peter Maydell <address@hidden>
> wrote:
>
>> On 12 September 2016 at 10:19, Marc-André Lureau
>> <address@hidden> wrote:
>> > The only remaining function of qmp-commands.hx is to let us generate
>> > qmp-commands.txt from it. Replace qmp-commands.hx by qmp-commands.txt.
>> >
>> > We intend to move the documentation into the QAPI schema and generate
>> > qapi-commands.txt from it, but not right now.
>>
>> This is a bit sad, though I see that there were not all that
>> many actual docstrings to autogenerate from.
Actually no sadder than before. This patch merely drops the parts of
qmp-commands.hx that are no longer used, then renames the result to
docs/qmp-commands.txt. No change to the duplication of docs with the
QAPI schema. The actual de-duplication is in Marc-André's queue.
>> What's the plan for reintroducing autogeneration of the
>> protocol docs?
>>
>>
> I'll rebase my qapi-doc branch, do some cleanups, and submit (last update:
> https://github.com/elmarco/qemu/commits/qapi-doc). Trouble is the series
> got pretty large after I splitted all the documentation move. It's over 150
> patches iirc, but it helps a lot with reviewing. Should I send it by
> chunks, or should I send a single patch and points to the github branch for
> the details? other options?
Let's try chunks.
- [Qemu-devel] [PATCH v6 14/18] tests: add a test to check invalid args, (continued)
- [Qemu-devel] [PATCH v6 14/18] tests: add a test to check invalid args, Marc-André Lureau, 2016/09/12
- [Qemu-devel] [PATCH v6 16/18] build-sys: remove qmp-commands-old.h, Marc-André Lureau, 2016/09/12
- [Qemu-devel] [PATCH v6 15/18] monitor: use qmp_dispatch(), Marc-André Lureau, 2016/09/12
- [Qemu-devel] [PATCH v6 17/18] qmp-commands.hx: fix some styling, Marc-André Lureau, 2016/09/12
- [Qemu-devel] [PATCH v6 18/18] Replace qmp-commands.hx by docs/qmp-commands.txt, Marc-André Lureau, 2016/09/12
- Re: [Qemu-devel] [PATCH v6 00/18] qapi: remove the 'middle' mode, Markus Armbruster, 2016/09/12