[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH for-2.8 2/2] vhost-vsock: add virtio sockets dev
|
From: |
Claudio Imbrenda |
|
Subject: |
Re: [Qemu-devel] [PATCH for-2.8 2/2] vhost-vsock: add virtio sockets device |
|
Date: |
Mon, 12 Sep 2016 16:56:57 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 |
On 09/09/16 23:07, Michael S. Tsirkin wrote:
[...]
> Seems to fail build:
>
> /scm/qemu/hw/s390x/virtio-ccw.c:1664:4: error: ‘VirtioCcwDevice {aka
> struct VirtioCcwDevice}’ has no member named ‘bus_id’
> DEFINE_PROP_STRING("devno", VirtioCcwDevice, bus_id),
> ^
> /scm/qemu/hw/s390x/virtio-ccw.c:1664:49: error: ‘VirtioCcwDevice {aka
> struct VirtioCcwDevice}’ has no member named ‘bus_id’
> DEFINE_PROP_STRING("devno", VirtioCcwDevice, bus_id),
>
Yeah, I had noticed that too; I sent this one-liner to correct that
issue on August 23rd; since it's small, I'll copypaste it here (modulo
automatic linewraps):
--- virtio-ccw.c~ 2016-08-23 16:37:14.000000000 +0200
+++ virtio-ccw.c 2016-08-23 16:41:10.587853314 +0200
@@ -1661,7 +1661,7 @@
#ifdef CONFIG_VHOST_VSOCK
static Property vhost_vsock_ccw_properties[] = {
- DEFINE_PROP_STRING("devno", VirtioCcwDevice, bus_id),
+ DEFINE_PROP_CSS_DEV_ID("devno", VirtioCcwDevice, parent_obj.bus_id),
DEFINE_PROP_UINT32("max_revision", VirtioCcwDevice, max_rev,
VIRTIO_CCW_MAX_REV),
DEFINE_PROP_END_OF_LIST(),
hope it helps,
Claudio