qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v3 00/34] cmpxchg-based emulation of atomics


From: Alex Bennée
Subject: Re: [Qemu-devel] [PATCH v3 00/34] cmpxchg-based emulation of atomics
Date: Fri, 09 Sep 2016 20:29:44 +0100
User-agent: mu4e 0.9.17; emacs 25.1.12

Richard Henderson <address@hidden> writes:

> On 09/09/2016 11:33 AM, Alex Bennée wrote:
>>
>> Richard Henderson <address@hidden> writes:
>>
>>> Changes since v2:
>>>   * Fix build for 32-bit host without 64-bit atomics.
>>>     Tested with --extra-cflags='-march=-i486'.
>>>     This is patch 15, which might ought to get folded back into
>>>     patch 13 for bisection, but is ugly for review.
>>
>> Hmm I wonder what's breaking the configure script on Travis:
>>
>>     https://travis-ci.org/stsquad/qemu/builds/158784781
>>
>> It's not very forthcoming with detail....
>
> Huh.  Well, I can attempt a build with the same version of gcc, and see if
> that's enlightening.  Anything you could do to track that down would
> be helpful.

If your local system has docker you can add the attached file into
tests/docker/dockerfiles and then do:

    make address@hidden J=9 V=1

Attachment: travis.docker
Description: travis/ubuntu dockerfile

I ran:

    make address@hidden J=9 V=1 DEBUG=1

and then manually:

    /tmp/qemu-test/src/tests/docker/test-quick

and got the following config.log:

Attachment: config.log
Description: config.log from failed build

Of which:

config-temp/qemu-conf.c: In function 'main':
config-temp/qemu-conf.c:4:3: warning: implicit declaration of function 
'__atomic_load_16' [-Wimplicit-function-declaration]
config-temp/qemu-conf.c:4:3: warning: nested extern declaration of 
'__atomic_load_16' [-Wnested-externs]
config-temp/qemu-conf.c:5:3: warning: implicit declaration of function 
'__atomic_store_16' [-Wimplicit-function-declaration]
config-temp/qemu-conf.c:5:3: warning: nested extern declaration of 
'__atomic_store_16' [-Wnested-externs]
config-temp/qemu-conf.c:6:3: warning: implicit declaration of function 
'__atomic_compare_exchange_16' [-Wimplicit-function-declaration]
config-temp/qemu-conf.c:6:3: warning: nested extern declaration of 
'__atomic_compare_exchange_16' [-Wnested-externs]
/tmp/cc0imc8D.o: In function `main':
/tmp/qemu-test/src/tests/docker/config-temp/qemu-conf.c:4: undefined reference 
to `__atomic_load_16'
/tmp/qemu-test/src/tests/docker/config-temp/qemu-conf.c:5: undefined reference 
to `__atomic_store_16'
/tmp/qemu-test/src/tests/docker/config-temp/qemu-conf.c:6: undefined reference 
to `__atomic_compare_exchange_16'
collect2: ld returned 1 exit status
cc -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common 
-Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs 
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
-Wold-style-declaration -Wold-style-definition -Wtype-limits 
-fstack-protector-all -I/usr/include/p11-kit-1 -I/usr/include/libpng12 -o 
config-temp/qemu-conf.exe config-temp/qemu-conf.c -Wl,-z,relro -Wl,-z,now -pie 
-m64 -g
config-temp/qemu-conf.c: In function 'main':
config-temp/qemu-conf.c:12:8: warning: unused variable 'is_host64' 
[-Wunused-variable]
cc -Werror -fPIE -DPIE -m64 -mcx16 -D_GNU_SOURCE -D_FILE_OFFSET_BITS=64 
-D_LARGEFILE_SOURCE -Wstrict-prototypes -Wredundant-decls -Wall -Wundef 
-Wwrite-strings -Wmissing-prototypes -fno-strict-aliasing -fno-common 
-Wendif-labels -Wmissing-include-dirs -Wempty-body -Wnested-externs 
-Wformat-security -Wformat-y2k -Winit-self -Wignored-qualifiers 
-Wold-style-declaration -Wold-style-definition -Wtype-limits 
-fstack-protector-all -I/usr/include/p11-kit-1 -I/usr/include/libpng12 -o 
config-temp/qemu-conf.exe config-temp/qemu-conf.c -Wl,-z,relro -Wl,-z,now -pie 
-m64 -g
config-temp/qemu-conf.c: In function 'main':
config-temp/qemu-conf.c:12:8: error: unused variable 'is_host64' 
[-Werror=unused-variable]
cc1: all warnings being treated as errors


>
>
>>>   * Move a lot of stuff out of softmmu_template.h, and into cputlb.c.
>>>     This is both for code size reduction and readability.
>>
>> \o/
>
> :-)
>
>
> r~


--
Alex Bennée

reply via email to

[Prev in Thread] Current Thread [Next in Thread]